Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enhance config override at compile time. #221

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Sep 26, 2022

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

refactor: enhance config override at compile time when the attribute operator is the override operator =.

  • kclvm/sema/src/pre_process/config.rs

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/sema/src/pre_process/tests.rs

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added the semantic Issues or PRs related to kcl semantic and checker label Sep 26, 2022
@Peefy Peefy added this to the v0.4.4 Release milestone Sep 26, 2022
@Peefy Peefy self-assigned this Sep 26, 2022
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 3127961305

  • 26 of 34 (76.47%) changed or added relevant lines in 2 files are covered.
  • 222 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.5%) to 57.987%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/pre_process/tests.rs 19 27 70.37%
Files with Coverage Reduction New Missed Lines %
kclvm/parser/src/lexer/indent.rs 4 78.31%
kclvm/parser/src/lexer/mod.rs 4 80.78%
kclvm/ast/src/token_stream.rs 6 78.57%
kclvm/sema/src/ty/mod.rs 35 66.02%
kclvm/3rdparty/rustc_span/src/analyze_source_file.rs 48 75.26%
kclvm/parser/src/lib.rs 54 83.44%
kclvm/sema/src/resolver/scope.rs 71 60.56%
Totals Coverage Status
Change from base Build 3126390738: -0.5%
Covered Lines: 20404
Relevant Lines: 35187

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Peefy Peefy merged commit d9a9975 into kcl-lang:main Sep 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2022
@Peefy Peefy deleted the enhance-override-config-at-compile-time branch November 4, 2022 12:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
semantic Issues or PRs related to kcl semantic and checker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants